248 orchestration depositForBurn #11037
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Hibbert
added
enhancement
Chris-Hibbert
force-pushed
the
248-orch-depositForBurn
branch
from
d739417 to
0abd3e5
Compare
Deploying agoric-sdk with
|
| Latest commit: |
c53d369
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6fa24239.agoric-sdk.pages.dev |
| Branch Preview URL: | https://248-orch-depositforburn.agoric-sdk.pages.dev |
Chris-Hibbert
force-pushed
the
248-orch-depositForBurn
branch
3 times, most recently
from
db7718d to
2d757f2
Compare
Chris-Hibbert
force-pushed
the
248-orch-depositForBurn
branch
from
9a7ff8a to
86cd97d
Compare
Chris-Hibbert
commented
Mar 5, 2025
| Fail`Chain Info not found for ${q(chainId)}`; | ||
| const chainName = chainIdToChainName.get(chainId); | ||
| chainInfos.has(chainName) || Fail`Chain Info not found for ${q(chainId)}`; | ||
| return /** @type {ActualChainInfo<chainName>} */ ( |
There was a problem hiding this comment.
does it make sense that getChainInfo returns ActualChainInfo<K>, while this returns Vow<ActualChainInfo<K>>?
I couldn't find a way to effectively apply a type to osmosis in const [_, osmosis, connectionInfo] =
Chris-Hibbert
force-pushed
the
248-orch-depositForBurn
branch
from
86cd97d to
c53d369
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #251
refs: #XXXX
Description
Support for depositForBurn in orchestration. Thanks for much help from @dckc and @0xpatrickdev.
Waiting for #11007. I started working on generalizing chainIDs, but #11007 is canonical.
The current state doesn't repair lint errors relating to chainIDs, and will need to be reconciled when that's final.
Security Considerations
No special hazards.
Scaling Considerations
This just transmits instructions. No records are kept. No particular consequence of high transaction volume.
Documentation Considerations
No impact.
Testing Considerations
Runs tests using mock bridges. More thorough testing will be called for on a testNet.
Upgrade Considerations
No particular impact on upgrade.